Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Python 3.8 support #2047

Merged
merged 2 commits into from
Oct 15, 2024
Merged

Remove Python 3.8 support #2047

merged 2 commits into from
Oct 15, 2024

Conversation

mr-c
Copy link
Member

@mr-c mr-c commented Oct 4, 2024

As per https://cwltool.readthedocs.io/en/latest/pythonversions.html

Do not merge until Python 3.8 is officially declared to have reached its End of Life (expected by the end of this month, October 2024)

Copy link

codecov bot commented Oct 4, 2024

Codecov Report

Attention: Patch coverage is 97.23183% with 8 lines in your changes missing coverage. Please review.

Project coverage is 83.93%. Comparing base (83def6a) to head (0ac6018).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
cwltool/cwlprov/provenance_profile.py 83.33% 2 Missing ⚠️
cwltool/main.py 86.66% 1 Missing and 1 partial ⚠️
cwltool/builder.py 91.66% 1 Missing ⚠️
cwltool/cwlrdf.py 66.66% 1 Missing ⚠️
cwltool/docker.py 87.50% 0 Missing and 1 partial ⚠️
cwltool/singularity.py 87.50% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2047      +/-   ##
==========================================
+ Coverage   83.88%   83.93%   +0.05%     
==========================================
  Files          46       46              
  Lines        8274     8300      +26     
  Branches     2102     1957     -145     
==========================================
+ Hits         6941     6967      +26     
- Misses        855      856       +1     
+ Partials      478      477       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mr-c mr-c force-pushed the drop_py38 branch 3 times, most recently from e7aa2b4 to 3d6fa92 Compare October 4, 2024 14:10
@mr-c mr-c changed the title drop py38 Remove Python 3.8 support Oct 4, 2024
@mr-c mr-c marked this pull request as ready for review October 15, 2024 15:36
@mr-c mr-c merged commit a956766 into main Oct 15, 2024
46 checks passed
@mr-c mr-c deleted the drop_py38 branch October 15, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant