Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Sample Extract #151

Closed
MichaelKohler opened this issue Jul 17, 2021 · 1 comment
Closed

Fix Sample Extract #151

MichaelKohler opened this issue Jul 17, 2021 · 1 comment
Assignees
@MichaelKohler
Labels
bug Something isn't working extract-improvements P1 tooling

Comments

@MichaelKohler
Copy link
Member

Currently the Sample extract on Pull Requests is broken. It extracts 30s of each part, and not 30s in total. This means that the sample extract runs for a longer time than necessary. This was broken by me when re-introducing the dump parts. We should only download one part dump, and extract 30s from that, nothing more.
@MichaelKohler MichaelKohler self-assigned this Jul 17, 2021
@MichaelKohler
Copy link
Member Author

Fixed in #150

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MichaelKohler MichaelKohler

Labels
bug Something isn't working extract-improvements P1 tooling
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@MichaelKohler