Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update teardown section in README and Makefile #255

Open
aspcanada opened this issue Jan 27, 2022 · 1 comment
Open

Update teardown section in README and Makefile #255

aspcanada opened this issue Jan 27, 2022 · 1 comment
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@aspcanada
Copy link

There are a few discrepancies in the Makefile and the README with respect to tearing down an environment.

  1. teardown-secrets removes the ci-user secret key which is shared b/t envs.
  2. teardown-secrets also removed the -eks-cluster-creator role which is also shared b/t envs.
  3. teardown should accept an environment param and should skip "shared" teardown steps.

Should have a teardown-shared-secrets and teardown-shared-roles make commands.

@aspcanada aspcanada changed the title Update teardown section in README Update teardown section in README and Makefile Jan 27, 2022
@bmonkman
Copy link
Contributor

Yeah that's true, we should probably add a note before tearing down shared resources that you should repeat the previous steps for any other environments, and like you mentioned, split teardown-secrets into two targets, one for env-specific resources and one for shared.

@bmonkman bmonkman added bug Something isn't working good first issue Good for newcomers labels Jan 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
Status: Backlog
Development

No branches or pull requests

2 participants