Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add support for supplying description when creating secrets #68

Merged
merged 2 commits into from
Nov 15, 2021
Merged

feat: Add support for supplying description when creating secrets #68

merged 2 commits into from
Nov 15, 2021

Conversation

bmonkman
Copy link
Contributor

Description

Please explain the changes you made here and link to any relevant issues.

Checklist

@bmonkman bmonkman requested a review from a team as a code owner November 11, 2021 01:08
@bmonkman bmonkman requested a review from davidcheung November 11, 2021 01:08
davidcheung
davidcheung approved these changes Nov 12, 2021
View reviewed changes
Copy link
Contributor

@davidcheung davidcheung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

other than the typo
LGTM

@bmonkman @davidcheung
Fix typo in variable
9c290d8 
Co-authored-by: David Cheung <[email protected]>
@github-actions
Copy link

Terraform Format and Style 🖌success

Terraform Initialization ⚙️success

Terraform Validation 🤖Success! The configuration is valid.

@bmonkman bmonkman merged commit 2078787 into main Nov 15, 2021
@bmonkman bmonkman deleted the add-secret-description branch November 15, 2021 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidcheung davidcheung davidcheung approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bmonkman @davidcheung