improvement: support user-auth local dev kratos #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Terraform Format and Style 🖌
|
davidcheung
commented
Sep 9, 2021
modules/user_auth/variables.tf
Outdated
| @@ -93,3 +93,15 @@ variable "kratos_default_redirect_ui_path" { | |||
| type = string | |||
| default = "/dashboard" | |||
| } | |||
|
|
|||
| variable "disable_oathkeeper" { | |||
| description = "To not provision Oathkeeper" | |||
There was a problem hiding this comment.
explain why rules are still used, and why this is useful
Terraform Format and Style 🖌
|
kratos redirect URLs are driven by config and are static, this will allow spining up another instance of user_auth(kratos) without oathkeeper, and allow the cookies to be sent cross-site 127.0.0.1:3000 -> backend on the cloud (for dev-env) allow modifying scheme allowing dev-instance of kratos with localhost
davidcheung
force-pushed
the
dev-env-to-support-user-auth
branch
from
de8c60f to
455f496
Compare
Terraform Format and Style 🖌
|
1 similar comment
Terraform Format and Style 🖌
|
bmonkman
reviewed
Sep 9, 2021
modules/user_auth/README.md
Outdated
| @@ -35,6 +35,8 @@ No requirements. | |||
| | backend\_service\_domain | Domain of the backend service | `string` | n/a | yes | | |||
| | cookie\_signing\_secret\_key | Default secret key for signing cookies | `string` | n/a | yes | | |||
| | create\_namespace | Whether to create the auth namespace(defaults to true), otherwise just references the namespace | `bool` | `true` | no | | |||
| | disable\_frontend\_https | Whether frontend URLs should be https, unless your developing locally you should leave the default as is. | `bool` | `false` | no | | |||
There was a problem hiding this comment.
Mind inverting this? Maybe something like frontend_use_https with a default of true. The double negative of disabled=false is harder to understand.
Terraform Format and Style 🖌
|
bmonkman
approved these changes
Sep 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kratos redirect URLs are driven by config and are static,
this will allow spining up another instance of user_auth(kratos) without
oathkeeper, and allow the cookies to be sent cross-site
127.0.0.1:3000 -> backend on the cloud (for dev-env)
allow modifying scheme allowing dev-instance of kratos with localhost
Description
Please explain the changes you made here and link to any relevant issues.
Checklist