Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for signed url downloads #4

Merged
merged 1 commit into from
Sep 11, 2020
Merged

feat: Add support for signed url downloads #4

merged 1 commit into from
Sep 11, 2020

Conversation

GrooveStomp
Copy link
Contributor

@GrooveStomp GrooveStomp commented Sep 11, 2020

Description

Add support for signed url downloads

https://app.zenhub.com/workspaces/commit-zero-5da8decc7046a60001c6db44/issues/commitdev/zero/268

  • New variable: cf_signed_downloads
  • Set trusted_signers when cf_signed_downloads is true

Checklist

@github-actions
Copy link

Terraform Format and Style 🖌success

Terraform Initialization ⚙️success

Terraform Validation 🤖Success! The configuration is valid.

https://app.zenhub.com/workspaces/commit-zero-5da8decc7046a60001c6db44/issues/commitdev/zero/268

- New variable: cf_signed_downloads
- Set trusted_signers when cf_signed_downloads is true
@github-actions
Copy link

Terraform Format and Style 🖌success

Terraform Initialization ⚙️success

Terraform Validation 🤖Success! The configuration is valid.

Copy link
Contributor

@bmonkman bmonkman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@GrooveStomp GrooveStomp merged commit 34172b0 into main Sep 11, 2020
@GrooveStomp GrooveStomp deleted the zero-268 branch September 11, 2020 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants