Memory leak in example_tenet

[synacktiv-rj]

Hello,

A memory leak occurs in the loop used to call ttdcursor.ReplayForward, since the caller of Cursor::GetCrossPlatformContext must free the context, and this is never done.

Here, the previous context containing the allocation is overriden without beeing freeed:

ttd-bindings/example_tenet/main.cpp

Line 243 in fb836bd

old_context = new_context;

My quick fix to deal with this issue was:

if (old_context)
    free(old_context);

I think the context should also be freed when this condition is true:

ttd-bindings/example_tenet/main.cpp

Lines 239 to 240 in fb836bd

	if (new_context->Rip < addr_min || new_context->Rip >= addr_max)
	continue;

Rémi

[mrexodia]

I changed the way the context is allocated in my fork. Still waiting for my other two PRs to be merged though…

[commial]

Hi there,

@synacktiv-rj: you're obviously right, and I can easily reproduce it when running the example_tenet exe on a ~300MB trace.

@mrexodia : I've indeed been away from this repo for a few month, but I've since merged your cmake PR (thanks, again).
If you still want to contribute to this repo, I would be happy to merge your context allocation changes.

[mrexodia]

Alright, I’ll try to upstream them. Locally I started a full rewrite, but obviously life got in the way and it didn’t get very far 😅