Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Docker with any image #936

Closed
borsboom opened this issue Sep 6, 2015 · 2 comments
Closed

Support Docker with any image #936

borsboom opened this issue Sep 6, 2015 · 2 comments

Comments

@borsboom
Copy link
Contributor

borsboom commented Sep 6, 2015

Since Docker support was originally implemented in an internal build tool, much has changed in stack. Those changes mean the structure of the Docker image is much less important than it used to be, and there's no deep reason for the Docker image to need a special structure anymore. Changes required, as far as I know:

  • Move the /usr/local/sbin/docker-entrypoint logic into Stack itself (and remove the entrypoint from future images, after a transition period).
  • Make stack itself behave as a proper PID 1 init daemon (reap processes, etc.). That means no more need to use phusion/baseimage's my_init.

We will continue to distribute images, but just about any image should work, including the Official Haskell images. Even images that don't contain GHC should work (stack will just fall back on its usual non-Docker behaviour of installing its own GHC in ~/.stack).

@edofic
Copy link

edofic commented Sep 7, 2015

This would enable using ghc with musl to build proper static binaries just with a repo setting. 👍

@borsboom
Copy link
Contributor Author

borsboom commented Sep 7, 2015

This is a duplicate of #531.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants