Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rationalise Package type's packageDeps, packageAllDeps and/or packageSubLibDeps fields #6065

Closed
mpilgrem opened this issue Mar 4, 2023 · 1 comment

Comments

@mpilgrem
Copy link
Member

mpilgrem commented Mar 4, 2023

This arises out of a code comment in #5659. The data constructor of the Package type now includes fields:

, packageDeps :: !(Map PackageName DepValue)
  -- ^ Packages that the package depends on, both as libraries and build tools.
, packageAllDeps :: !(Set PackageName)
  -- ^ Original dependencies (not sieved).
, packageSubLibDeps :: !(Map MungedPackageName DepValue)
  -- ^ Original sub-library dependencies (not sieved).

The question is: is some or all of that duplicative and capable of rationalisation? The answer to that question is likely downstream of solving the residual problem of getting sub-library dependencies to work (eg #5839).

@theobat
Copy link
Contributor

theobat commented Dec 4, 2023

We should do the same in LocalPackage but closing this one for now as most of it is done

@theobat theobat closed this as completed Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants