Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--ghc-options (or --fast / --pedantic) get applied to extra-deps #1631

Open
mgsloan opened this issue Jan 9, 2016 · 4 comments
Open

--ghc-options (or --fast / --pedantic) get applied to extra-deps #1631

mgsloan opened this issue Jan 9, 2016 · 4 comments

Comments

@mgsloan
Copy link
Contributor

mgsloan commented Jan 9, 2016

See haskell/haskell-ide-engine#165 (comment) . The issue is that ghc-options get applied to a package like this

- location:
    git: https://github.com/kazu-yamamoto/ghc-mod.git
    commit: b9bd4ebf77b22d2d9061d647d7799ddcc7c51228
  extra-dep: true

Even though apply-ghc-options is its default value, local.

@cocreature
Copy link
Contributor

I thought #1272 was the same issue (which is why I didn’t already open one). That issues is closed but with a comment that #1265 will fix this which is still open.

@mgsloan mgsloan changed the title ghc-options get applied to extra-dep packages from git --ghc-options (or --fast / --pedantic) get applied to extra-dep packages from git Jan 9, 2016
@mgsloan
Copy link
Contributor Author

mgsloan commented Jan 9, 2016

I see! I didn't find that issue since it's specific to --pedantic, and closed. I'm going to leave this one open for now to avoid further dupes.

@mgsloan mgsloan changed the title --ghc-options (or --fast / --pedantic) get applied to extra-dep packages from git --ghc-options (or --fast / --pedantic) get applied to extra-deps Jan 10, 2016
@mboes
Copy link
Contributor

mboes commented Jan 10, 2016 via email

@mgsloan mgsloan removed the type: bug label Jan 10, 2016
@borsboom
Copy link
Contributor

extra-deps are currently local packages, so having those flags apply when apply-ghc-options: local is technically correct. The problem is that extra-deps shouldn't be local packages, and that's one of the things that the extra-dep/snapshot unification addresses. I'd rather that any time spent on this be put toward the extra-dep/custom snapshot unification than a temporary hack. That really is the #1 thing to get finished for Stack right now; a lot of other things are blocked on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants