Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly mock file and dirs in app tests to not read from the filesystem #149

Closed
dylanhitt opened this issue Oct 21, 2020 · 0 comments · Fixed by #152
Closed

Properly mock file and dirs in app tests to not read from the filesystem #149

dylanhitt opened this issue Oct 21, 2020 · 0 comments · Fixed by #152

Comments

@dylanhitt
Copy link
Member

Description

Shown in this build failure. The test in apps is currently targeting example suites in examples/. This should be properly mocked.
@dylanhitt dylanhitt changed the title Properly mock ioutil.ReadFile in app to not read from the filesystem Properly mock ioutil.ReadFile in app to not read from the filesystem Oct 21, 2020
@dylanhitt dylanhitt changed the title Properly mock ioutil.ReadFile in app to not read from the filesystem Properly mock ioutil.ReadFile in app to not read from the filesystem Oct 21, 2020
This was referenced Oct 23, 2020
Merged
Closed
@dylanhitt dylanhitt changed the title Properly mock ioutil.ReadFile in app to not read from the filesystem Properly mock file and dirs in app tests to not read from the filesystem Oct 23, 2020
@dylanhitt dylanhitt mentioned this issue Nov 3, 2020
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@dylanhitt