Skip to content
This repository has been archived by the owner on Mar 23, 2021. It is now read-only.

Remove dbg! macros from master (and prevent it) #760

Closed
thomaseizinger opened this issue Feb 15, 2019 · 0 comments
Closed

Remove dbg! macros from master (and prevent it) #760

thomaseizinger opened this issue Feb 15, 2019 · 0 comments
Assignees
@luckysori
Milestone
Sprint 10 🍻🤪

Comments

@thomaseizinger
Copy link
Contributor

thomaseizinger commented Feb 15, 2019 •
edited by D4nte
Loading

Those macros should either be removed or replaced with proper log statements (hint: they are in the noise handshake crate).

If I am not mistaken, dbg macros are not meant to be present in production code

Activate new clippy warn as part of this issue (will need a toolchain update)
@comit-network comit-network deleted a comment from thomaseizinger Feb 17, 2019
@D4nte D4nte changed the title Noise handshake uses dbg! macros Remove dbg! macros from master (and prevent it) Feb 17, 2019
@D4nte D4nte added the groomed label Feb 17, 2019
@luckysori luckysori self-assigned this Feb 26, 2019
@luckysori luckysori mentioned this issue Feb 26, 2019
Merged
@ghost ghost added review and removed work-in-progress labels Feb 26, 2019
@D4nte D4nte added this to the Sprint 10 🍻🤪 milestone Feb 27, 2019
@LLFourn LLFourn closed this as completed Feb 28, 2019
@ghost ghost removed the review label Feb 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@luckysori luckysori

Labels
None yet
Projects
None yet
Milestone
Sprint 10 🍻🤪
Development

No branches or pull requests
4 participants
@D4nte @LLFourn @thomaseizinger @luckysori