Skip to content
This repository has been archived by the owner on Mar 23, 2021. It is now read-only.

Re-add the certificate check for lnd on macOS #2486

Closed
da-kami opened this issue Apr 19, 2020 · 1 comment
Closed

Re-add the certificate check for lnd on macOS #2486

da-kami opened this issue Apr 19, 2020 · 1 comment

Comments

@da-kami
Copy link
Member

da-kami commented Apr 19, 2020

Problem

Due to #2464 (comment) we changed comit-rs' compilation for macOS to not include the certificate check:

#[cfg(target_os = "macos")]
let client = reqwest::Client::builder()
.danger_accept_invalid_certs(true)
.add_root_certificate(cert)
.default_headers(default_headers)
.build()?;

Goal

Remove the conditional compilation that excludes certificate validation on macOS.

There is already a fix on the certificate generation for lnd on the way: lightningnetwork/lnd#4201

I could confirm that this change fixes the problem on my machine.

Once lightningnetwork/lnd#4201 is closed and the change goes into a new release we can upgrade to the new lnd version and remove the conditional compilation on macOS.

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant