Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CM-2347]: Implement equivalent of API.get_registry_model_count #76

Merged
merged 2 commits into from
Oct 12, 2022

Conversation

yaricom
Copy link
Member

@yaricom yaricom commented Oct 12, 2022

comet-java-client

  • Implemented CometApi.getRegistryModelsCount() allowing to get number of models registered under specific workspace.

comet-examples

  • Implemented examples of how to use CometApi method to get number of registered models under specific workspace.

@sonatype-lift
Copy link

sonatype-lift bot commented Oct 12, 2022

⚠️ 4 God Classes were detected by Lift in this project. Visit the Lift web console for more details.

@codecov-commenter
Copy link

Codecov Report

Base: 63.50% // Head: 63.52% // Increases project coverage by +0.02% 🎉

Coverage data is based on head (bb1a56c) compared to base (e964d77).
Patch coverage: 68.75% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##             master      #76      +/-   ##
============================================
+ Coverage     63.50%   63.52%   +0.02%     
- Complexity     1018     1022       +4     
============================================
  Files           134      135       +1     
  Lines          3992     4008      +16     
  Branches        346      347       +1     
============================================
+ Hits           2535     2546      +11     
- Misses         1003     1006       +3     
- Partials        454      456       +2     
Flag Coverage Δ
integration 63.52% <68.75%> (+0.02%) ⬆️
unittests 63.52% <68.75%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../comet/experiment/impl/constants/ApiEndpoints.java 0.00% <ø> (ø)
...l/comet/experiment/impl/resources/LogMessages.java 30.76% <ø> (ø)
...periment/impl/rest/RegistryModelCountResponse.java 50.00% <50.00%> (ø)
...in/java/ml/comet/experiment/impl/CometApiImpl.java 69.06% <70.00%> (+0.03%) ⬆️
...n/java/ml/comet/experiment/impl/RestApiClient.java 69.48% <100.00%> (+0.28%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@yaricom yaricom merged commit a0333e2 into master Oct 12, 2022
@yaricom yaricom deleted the CM-2347-registry-model-count branch October 12, 2022 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants