-
-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scala LTS 3.3.3 #610
Closed
Closed
Scala LTS 3.3.3 #610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Error: [#0] [error] -- Error: /home/runner/work/upickle/upickle/upickle/test/src/upickle/ClassDefs.scala:209:34
Error: [#0] [error] 209 | implicit def rw: RW[ClsA] = default.macroRW
Error: [#0] [error] | ^^^^^^^^^^^^^^^
Error: [#0] [error] |Exception occurred while executing macro expansion.
Error: [#0] [error] |java.lang.ClassCastException: dotty.tools.dotc.ast.Trees$This cannot be cast to dotty.tools.dotc.ast.Trees$RefTree
Error: [#0] [error] | at scala.quoted.runtime.impl.QuotesImpl.scala$quoted$runtime$impl$QuotesImpl$reflect$Ref$$$_$apply$$anonfun$6(QuotesImpl.scala:446)
Error: [#0] [error] | at scala.quoted.runtime.impl.QuotesImpl$reflect$.scala$quoted$runtime$impl$QuotesImpl$reflect$$$withDefaultPos(QuotesImpl.scala:3002)
Error: [#0] [error] | at scala.quoted.runtime.impl.QuotesImpl$reflect$Ref$.apply(QuotesImpl.scala:446)
Error: [#0] [error] | at scala.quoted.runtime.impl.QuotesImpl$reflect$Ref$.apply(QuotesImpl.scala:444)
Error: [#0] [error] | at upickle.implicits.macros.macros$package$.apply$1(macros.scala:260)
Error: [#0] [error] | at upickle.implicits.macros.macros$package$.applyConstructorImpl(macros.scala:268)
Error: [#0] [error] |
Error: [#0] [error] |---------------------------------------------------------------------------
Error: [#0] [error] |Inline stack trace
Error: [#0] [error] |- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
Error: [#0] [error] |This location contains code that was inlined from macros.scala:224
Error: [#0] [error] 224 |inline def applyConstructor[T](params: Array[Any]): T = ${ applyConstructorImpl[T]('params) }
Error: [#0] [error] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Error: [#0] [error] |- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
Error: [#0] [error] |This location contains code that was inlined from macros.scala:224
Error: [#0] [error] 65 | params => macros.applyConstructor[T](params)
Error: [#0] [error] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Error: [#0] [error] |- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
Error: [#0] [error] |This location contains code that was inlined from macros.scala:224
Error: [#0] [error] 11 | ReadWriter.join(macroR[T], macroW[T])
Error: [#0] [error] | ^^^^^^^^^
Error: [#0] [error] ---------------------------------------------------------------------------
[#2] [info] done compiling |
maybe try it with 3.3.5-RC1-bin-20240712-4eb7668-NIGHTLY, as many 3.x PRs have now been backported to the 3.3 LTS series (I found that version number by running |
ohey, looks like it works. Seems like we'll be able to bring back support for 3.x as long as 3.3.5 comes out some time in the near future |
I don't understand why it fails for Native :( |
@lihaoyi please run 🙏 |
Done in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.