Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #440: fix for allowing subgroups of a given staging profile #441

Merged
merged 1 commit into from
Oct 5, 2018

Conversation

bbarker
Copy link
Contributor

@bbarker bbarker commented Sep 28, 2018

Probably due to my raging cold, but I had it backwards in the issue.

@bbarker bbarker mentioned this pull request Sep 28, 2018
@lihaoyi
Copy link
Member

lihaoyi commented Oct 2, 2018

Maybe we could split it on . and use Seq#startsWith? We don't want com.lihaoyi to be treated as a prefix of com.lihaoyi2

@bbarker bbarker force-pushed the publish_by_subGroupId branch from 3ab6568 to c220f38 Compare October 2, 2018 17:53
@bbarker
Copy link
Contributor Author

bbarker commented Oct 2, 2018

Nice catch - I tested it and it seems to work (updated commit in PR)

@lihaoyi lihaoyi merged commit 114208c into com-lihaoyi:master Oct 5, 2018
ucbjrl pushed a commit to ucbjrl/mill that referenced this pull request Oct 9, 2018
ucbjrl pushed a commit to ucbjrl/mill that referenced this pull request Oct 9, 2018
@lefou lefou added this to the 0.2.9 milestone Apr 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants