Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Play framework support - routes compiler #324

Closed
rockjam opened this issue May 14, 2018 · 8 comments
Closed

Play framework support - routes compiler #324

rockjam opened this issue May 14, 2018 · 8 comments

Comments

@rockjam
Copy link
Contributor

rockjam commented May 14, 2018

To build play applications with mill we need to implement compilation of play routes. https://github.com/playframework/playframework/blob/master/framework/src/sbt-plugin/src/main/scala/play/sbt/routes/RoutesCompiler.scala

@ggrossetie
Copy link
Contributor

I'm working on it 😉
@rockjam Could you please assign it to me ?

Here's a work in progress: master...Mogztter:playlib

Do you think we should move the Twirl Compiler inside a playlib module ?

@rockjam
Copy link
Contributor Author

rockjam commented Jun 28, 2018

@Mogztter for some reason I can't assign you. But I think it's enough that you mentioned that fact here.

@ggrossetie
Copy link
Contributor

Ok thanks.
@rockjam Do you have an opinion on "Do you think we should move the Twirl Compiler inside a playlib module ?" ?

@rockjam
Copy link
Contributor Author

rockjam commented Jul 17, 2018

@Mogztter I don't have strong opinion on this one. Feel free to move it in playlib module if you wish

@dbuschman7
Copy link

@Mogztter Is there still progress happening on this?

@ggrossetie
Copy link
Contributor

Yes I will open a pull request in the next few days (still a work in progress though)

@dbuschman7
Copy link

Ok, I can help in a few days to get it "over the line" if needed.

I know I will need multiple routes files to be added for one of my apps.

@lihaoyi
Copy link
Member

lihaoyi commented Dec 15, 2018

closing due to inactivity

@lihaoyi lihaoyi closed this as completed Dec 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants