Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend source file cache invalidation granularity to vanilla .scala files #2636

Closed
lolgab opened this issue Jun 26, 2023 · 1 comment
Closed
Milestone

Comments

@lolgab
Copy link
Member

lolgab commented Jun 26, 2023

Mill's current cache has cache invalidation which has build file granularity.
If you have two files build.sc and other.sc and build.sc imports other.sc, changes in build.sc don't invalidate caches for targets defined in other.sc.
This works only with .sc since they explicitly state dependencies via import $file imports.
It would be nice to extend this to vanilla Scala files.
acyclic can track dependencies between vanilla Scala files. We could use something like it to implement the same support we currently have for *.sc files to *.scala files in the mill-build/src directory.

@lihaoyi
Copy link
Member

lihaoyi commented Jul 30, 2023

Superseded by #2417, which implements fine grained method-level code change invalidation that works the same for .sc files and .scala files alike (and .java files too)

@lihaoyi lihaoyi closed this as completed Jul 30, 2023
@lefou lefou added this to the 0.11.2 milestone Jul 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants