Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build server cannot start if build.sc import file with backtick #2361

Closed
jilen opened this issue Mar 17, 2023 · 3 comments
Closed

Build server cannot start if build.sc import file with backtick #2361

jilen opened this issue Mar 17, 2023 · 3 comments
Labels
bug The issue represents an bug

Comments

@jilen
Copy link
Contributor

jilen commented Mar 17, 2023

Version : 0.11.0-M6
For example

import $file.`a-b`

Then the bsp server says

File not found /path/to/`a-b`.sc

Seems the backtick is not removed from the path.

@lefou lefou added the bug The issue represents an bug label Mar 17, 2023
@lefou
Copy link
Member

lefou commented Mar 17, 2023

Thanks for the report.

The affected code path is rather new and uses a pretty trivial regex. The best solution would be to correctly parse the import as it is done in Ammonite.

@lefou
Copy link
Member

lefou commented Mar 31, 2023

We're in the process to completely rework the processing of build.sc files.

This change will also use a parser almost equal to the one used in Ammonite, so I think this issue will also resolve once we finish.

@jilen
Copy link
Contributor Author

jilen commented Apr 25, 2023

Tracked with #2458 instead

@jilen jilen closed this as completed Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug The issue represents an bug
Projects
None yet
Development

No branches or pull requests

2 participants