room.Send() should throw an error if the send failed, rather than returning silently

[rnd256]

No description provided.

[endel]

Hi @rnd256, thanks for reporting as always.

Forgive my ignorance but in which situation would room.Send() fail? I can only think of operating on a disconnected WebSocket, if that's what you're referring to we should make it throw an error indeed!

[rnd256]

Hi @endel, thanks for the fast response as always :)

That's exactly what I'm referring to! Here are the two spots where I think an issue could occur:

• https://github.com/colyseus/colyseus-unity3d/blob/4472b4db8ba39a7705d001b96b86d18cee3218ea/Assets/Colyseus/Runtime/WebSocket/WebSocket.cs#L485
• https://github.com/colyseus/colyseus-unity3d/blob/4472b4db8ba39a7705d001b96b86d18cee3218ea/Assets/Colyseus/Runtime/WebSocket/WebSocket.cs#L492

[tonygiang]

+1

I don't know if a disconnection detected by the Colyseus client will always be detected by the server, but having a confirmation that a disconnection did happen client-side will help with problem diagnosis greatly, and identify such cases.