Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Legacy builds are not included in NPM package. #232

Closed
jgerigmeyer opened this issue Oct 31, 2022 · 6 comments · Fixed by #233
Closed

Legacy builds are not included in NPM package. #232

jgerigmeyer opened this issue Oct 31, 2022 · 6 comments · Fixed by #233

Comments

@jgerigmeyer
Copy link
Member

New legacy builds were added in #215 to support older versions of Node etc, but it appears that the legacy built files are missing in the published NPM package for v0.4.1: https://unpkg.com/browse/[email protected]/dist/

I'm not sure what the build/release process is for colorjs.io, but when I npm pack locally the files are included correctly -- perhaps npm run build wasn't run before the new release? In case that's the issue, I'll open a PR to address that with a prepack script.

@LeaVerou
Copy link
Member

Ugh, I'm an idiot. 🤦🏽‍♀️ Yes, I released without running npm run build 🤦🏽‍♀️🤦🏽‍♀️🤦🏽‍♀️

@LeaVerou LeaVerou reopened this Oct 31, 2022
@LeaVerou
Copy link
Member

(Not closed until I release a patch version lol)

@LeaVerou
Copy link
Member

LeaVerou commented Oct 31, 2022

@jgerigmeyer Are you aware of any convention for what that version number would be? We currently use the "patch" version number for releases with actual features, since we're still in 0.x.y, so it would need to be a -something

@jgerigmeyer
Copy link
Member Author

@jgerigmeyer Are you aware of any convention for what that version number would be? We currently use the "patch" version number for releases with actual features, since we're still in 0.x.y, so it would need to be a -something

@LeaVerou Oh, that's a great question! I don't feel strongly, but my general approach is that during pre-1.0 I treat "patch" and "feature" the same, so I would lean toward v0.4.2 rather than v0.4.1-patch.1. (This is I think the main approach outlined in semver/semver#333, for example.) Partially because I find it confusing when the "current" release is a 0.x.y-something... but really I'm fine with whatever you prefer!

@jgerigmeyer
Copy link
Member Author

jgerigmeyer commented Nov 1, 2022

This seems to be fixed for me in v0.4.1-patch.1. I'm not sure why it's not working on unpkg, but maybe that's an issue on their end? It's available now on unpkg: https://unpkg.com/browse/[email protected]/dist/

One downside of using v0.4.1-patch.1 is that it's not installed by either ^0.4.1 or even ^0.4.1-patch.1, and can only be installed with 0.4.1-patch.1 directly. But that's probably best practice for a pre-1.0 dependency anyway, so 🤷

@LeaVerou
Copy link
Member

LeaVerou commented Nov 1, 2022

One downside of using v0.4.1-patch.1 is that it's not installed by either ^0.4.1 or even ^0.4.1-patch.1, and can only be installed with 0.4.1-patch.1 directly. But that's probably best practice for a pre-1.0 dependency anyway, so 🤷

Ah, I didn't know that. Even more reason to implement alpha blending and release it in 0.4.2!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants