Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests are failing #165

Closed
halnique opened this issue Jan 11, 2024 · 0 comments · Fixed by #166
Closed

Tests are failing #165

halnique opened this issue Jan 11, 2024 · 0 comments · Fixed by #166

Comments

@halnique
Copy link
Contributor

Overview

When I run the test on the master branch's latest commit 4f175f3, it fails.

$ composer test
> phpunit
PHPUnit 10.5.5 by Sebastian Bergmann and contributors.

Runtime:       PHP 8.1.27
Configuration: /project/phpunit.xml

........................S........E

Time: 01:07.252, Memory: 36.00 MB

There was 1 error:

1) Colopl\Spanner\Tests\ConnectionTest::test_connection_transaction_reset_on_exceptions
InvalidArgumentException: Rollback failed: Transaction not initiated.

/project/vendor/google/cloud-spanner/src/Operation.php:193
/project/vendor/google/cloud-spanner/src/Transaction.php:572
/project/src/Concerns/ManagesTransactions.php:172
/project/vendor/laravel/framework/src/Illuminate/Database/Concerns/ManagesTransactions.php:264
/project/src/Concerns/ManagesTransactions.php:73
/project/vendor/google/cloud-spanner/src/Database.php:957
/project/vendor/google/cloud-core/src/Retry.php:80
/project/vendor/google/cloud-spanner/src/Database.php:975
/project/src/Concerns/ManagesTransactions.php:76
/project/src/Connection.php:525
/project/src/Concerns/ManagesTransactions.php:81
/project/tests/ConnectionTest.php:541

ERRORS!
Tests: 34, Assertions: 105, Errors: 1, Skipped: 1.
Script phpunit handling the test event returned with error code 2

Setting the flags stopOnError=false and stopOnFailure=false in the test configuration results in 11 Errors and 6 Failures.

$ composer test
> phpunit
PHPUnit 10.5.5 by Sebastian Bergmann and contributors.

Runtime:       PHP 8.1.27
Configuration: /project/phpunit.xml

........................S........E.....FFFFF.E.................  63 / 167 ( 37%)
E.......................S...................................... 126 / 167 ( 75%)
.............E...F....EE...ESE..EEE......                       167 / 167 (100%)

Time: 05:34.611, Memory: 50.50 MB

...

ERRORS!
Tests: 167, Assertions: 512, Errors: 11, Failures: 6, Skipped: 3.
Script phpunit handling the test event returned with error code 2

It seems to be affected by the release of google/cloud-spanner v1.68.0.
I’m still investigating the scope of the correction, but I wanted to report it first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant