Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Value based equality #570

Closed
niccokunzmann opened this issue Oct 12, 2023 · 2 comments
Closed

Value based equality #570

niccokunzmann opened this issue Oct 12, 2023 · 2 comments

Comments

@niccokunzmann
Copy link
Member

It is to me easier to expect two calenders to equal if they have the same components and values.
#568 shows that some components or attributes use object identity when compared where value equality is expected. I open this issue to discuss this and wonder if we could transit to a unified approach to compare values. What would be the challenges?
What are your thoughts?
@niccokunzmann
Copy link
Member Author

I think that for a start, we could read in all calendar files that are there twice and compare the two. Some from niccokunzmann/x-wr-timezone#8 might also show which elements are not equal.

This was referenced Nov 1, 2023
Merged
Closed
@niccokunzmann
Copy link
Member Author

This is live in v5.0.11. Thanks for your contributions!
I will close this for now as it solves my use-cases. If any class escapes proper equality comparison, we should open another issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@niccokunzmann