Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Isn't the contributors guide needed on readme? #8

Open
vikaskyadav opened this issue Aug 4, 2018 · 9 comments
Open

Isn't the contributors guide needed on readme? #8

vikaskyadav opened this issue Aug 4, 2018 · 9 comments

Comments

@vikaskyadav
Copy link

No description provided.

@ajayns
Copy link
Collaborator

ajayns commented Aug 4, 2018

Right now the prime focus is to complete the starter with all the major features, adding this guide has been left for later. But would be more than glad to accept PRs! :)

@vinay72
Copy link
Contributor

vinay72 commented Jan 29, 2019

@ajayns Can I work on the contributor guide to add README.rst file for new contributors to know how to contribute to this repository?

@ajayns
Copy link
Collaborator

ajayns commented Feb 1, 2019

Sure! Maybe @cekk or @tisto can help us with a repo with a good contributors guide which can be used as reference.

@vinay72
Copy link
Contributor

vinay72 commented Feb 1, 2019

@datakurre @ajayns Can I add this file in this repository by sending a PR? You can check this link : https://docs.plone.org/develop/coredev/docs/agreement.html .

@datakurre
Copy link
Collaborator

@vinay72 Just create a PR and discussion would be easier to handle in that PR.

Technically this package is not yet under Plone Foundation, so it does not require to follow those rules, but sure it would not do any harm to follow them.

@vinay72
Copy link
Contributor

vinay72 commented Feb 10, 2019

@datakurre Whenever I try to push my commit from my remote branch, I am getting the following error in my terminal
screenshot from 2019-02-11 01-13-30

@datakurre
Copy link
Collaborator

datakurre commented Feb 10, 2019 via email

@ajayns
Copy link
Collaborator

ajayns commented Feb 15, 2019

Please read through the commonly used practices while contributing to open source and maybe work your way through Github before opening a proper PR. It doesn't make sense spamming this repo with PRs @vinay72

@vinay72
Copy link
Contributor

vinay72 commented Feb 16, 2019

@ajayns I am sorry for inconvenience. I'll take care next time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants