To-do for website #44
Replies: 12 comments 12 replies
-
|
Hi @KendallDoesCoding , I will complete the sidebar navigation once you merge the PR to the final branch on the docsify-test repo. I am not a docsify expert 😅 let me know when you are ready to integrate into this main project. |
Beta Was this translation helpful? Give feedback.
-
|
Hey Vikas. The PR is made by the branch "final" so the final website code
is currently in that branch. I only made the PR so we could get the deploy
preview link.
By that I meant, you know more then on docsify.
We will merge the final website once you finish making the sidebar using
Vue.js
Thanks,
KendallDoesCoding
|
Beta Was this translation helpful? Give feedback.
-
|
Okay, Then i will start working on it now. I will let you know once I completed it. |
Beta Was this translation helpful? Give feedback.
-
|
cool! let me know when it's done.
We can either make the journeys section very small with css, if possible,
or keep the sidebar only for journey's and move the other stuff to the
navbar.
|
Beta Was this translation helpful? Give feedback.
-
|
Hi, I added the user journey links to the sidebar. There are some issues 👇
Check it out → https://deploy-preview-2--neontuts-docsify-test.netlify.app/ |
Beta Was this translation helpful? Give feedback.
-
|
And docsify doesn't support Vue.js on the sidebar. It took too long to figure out the solution. But the better solution is to use github action to create those links on the sidebar. |
Beta Was this translation helpful? Give feedback.
-
|
For now it works, but we may have to find a gh-action.
Just realised, the sidebar doesnt work on mobile though, what should we do,
any ideas? Coz on the sidebar all the pages are listed.
…On Sat, 16 Jul 2022, 8:47 pm Vikas Ganiga, ***@***.***> wrote:
Hi, I added the user journey links to the sidebar. There are some issues
👇
- The title is not changing to the user's name.
- The journey section in the sidebar is refreshing every time when
sidebar links are clicked.
Check it out →
https://deploy-preview-2--neontuts-docsify-test.netlify.app/
—
Reply to this email directly, view it on GitHub
<#44 (reply in thread)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AUGJUTLBBJM3PU46HCHMWVLVULG7VANCNFSM53WHDM5A>
.
You are receiving this because you were mentioned.Message ID:
***@***.***
.com>
|
Beta Was this translation helpful? Give feedback.
-
|
The sidebar is working on mobile it's toggled off. The sidebar toggle button is hidden under the Netlify overlay. |
Beta Was this translation helpful? Give feedback.
-
|
Oh ok, makes sense. |
Beta Was this translation helpful? Give feedback.
-
|
@Adarsh-jaiss Please confirm if you like this website - https://deploy-preview-2--neontuts-docsify-test.netlify.app/ If you like the website @Adarsh-jaiss @vikasganiga05 , @vikasganiga05 Please create a PR to merge the website into this repo, you can make a branch in this repo and add the website code. Then, we'll talk about the domain, etc. |
Beta Was this translation helpful? Give feedback.
-
|
I like the website! |
Beta Was this translation helpful? Give feedback.
-
|
Yeah, I like it too. I created the GitHub Action for the sidebar links. I will add that to the test repo. |
Beta Was this translation helpful? Give feedback.
-
|
@KendallDoesCoding I modified this → https://github.com/marketplace/actions/json2table github-action. Which you shared a while ago 🙂 |
Beta Was this translation helpful? Give feedback.
-
|
Perfect! Thanks a ton!
…On Sun, 17 Jul 2022 at 15:16, Vikas Ganiga ***@***.***> wrote:
Yeah, I like it too. I created the GitHub action for the sidebar links. I
will add that to the test repo.
—
Reply to this email directly, view it on GitHub
<https://gessisc.com/click?redirect=https%3A%2F%2Fgithub.com%2Fcollab-community%2Fjourney-book%2Fdiscussions%2F44%23discussioncomment-3164612&dID=1658052651105&linkName=view
it on GitHub>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AUGJUTLYVPWQL6B56QDLBCTVUPJABANCNFSM53WHDM5A>
.
You are receiving this because you were mentioned.Message ID:
***@***.***
.com>
|
Beta Was this translation helpful? Give feedback.
-
|
You're welcome. I added the dark and light toggle. Check it out → https://deploy-preview-2--neontuts-docsify-test.netlify.app/ |
Beta Was this translation helpful? Give feedback.
-
|
For me, my chrome only is messed up, everything is darkmode for some
reason. ,Adarsh and Vikas please confirm if it's working properly.
…On Sun, 17 Jul 2022 at 16:24, Vikas Ganiga ***@***.***> wrote:
You're welcome. I added the dark and light toggle. Check it out →
https://deploy-preview-2--neontuts-docsify-test.netlify.app/
—
Reply to this email directly, view it on GitHub
<#44 (reply in thread)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AUGJUTLKHUPSZB6UL3Q73BLVUPQ6DANCNFSM53WHDM5A>
.
You are receiving this because you were mentioned.Message ID:
***@***.***
.com>
|
Beta Was this translation helpful? Give feedback.
-
|
It's working fine on the Firefox browser. 👇
|
Beta Was this translation helpful? Give feedback.
-
|
Oh nice, glad it was useful.
…On Sun, 17 Jul 2022 at 16:26, Vikas Ganiga ***@***.***> wrote:
@KendallDoesCoding <https://github.com/KendallDoesCoding> I modified this
→ https://github.com/marketplace/actions/json2table github-action. Which
you shared a while ago 🙂
—
Reply to this email directly, view it on GitHub
<#44 (reply in thread)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AUGJUTKHMKQ5HG436HRJCRLVUPRGFANCNFSM53WHDM5A>
.
You are receiving this because you were mentioned.Message ID:
***@***.***
.com>
|
Beta Was this translation helpful? Give feedback.
-
|
Ok cool.
Please merge the website to this repo
…On Sun, 17 Jul 2022, 5:29 pm Vikas Ganiga, ***@***.***> wrote:
It's working fine on the Firefox browser. 👇
[image: image]
<https://user-images.githubusercontent.com/74750414/179397129-6e677547-6386-4f6b-8ed4-0136f20e4995.png>
[image: image]
<https://user-images.githubusercontent.com/74750414/179397134-aeab230a-ad73-4a5c-b54d-c0b36fb2299b.png>
—
Reply to this email directly, view it on GitHub
<#44 (reply in thread)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AUGJUTNDRYMIEILOBLOR2GLVUPYSLANCNFSM53WHDM5A>
.
You are receiving this because you were mentioned.Message ID:
***@***.***
.com>
|
Beta Was this translation helpful? Give feedback.
-
|
Done 👍 Please review it. |
Beta Was this translation helpful? Give feedback.
-
|
Hi @Adarsh-jaiss & @KendallDoesCoding , I added the website code from the test repo to docsify branch. Here is the PR #47 . Please take a look at it. If anything is wrong please let me know. Thank You 🙏 |
Beta Was this translation helpful? Give feedback.
-
|
Hi Vikas.
Thanks a ton. Will review later in the day
…On Tue, 19 Jul 2022, 6:23 am Vikas Ganiga, ***@***.***> wrote:
Hi @Adarsh-jaiss <https://github.com/Adarsh-jaiss> & @KendallDoesCoding
<https://github.com/KendallDoesCoding> , I added the website code from
the test repo to *docsify
<https://github.com/collab-community/journey-book/tree/docsify>* branch.
Here is the PR #47
<#47> . Please take
a look at it. If anything is wrong please let me know.
Thank You 🙏
—
Reply to this email directly, view it on GitHub
<#44 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AUGJUTPNRMJFQPITJYRVDBLVUX4CDANCNFSM53WHDM5A>
.
You are receiving this because you were mentioned.Message ID:
***@***.***
.com>
|
Beta Was this translation helpful? Give feedback.
-
|
Your welcome 🙂 |
Beta Was this translation helpful? Give feedback.
-
|
@vikasganiga05 The website looks amazing, thanks for all the work you put into it! |
Beta Was this translation helpful? Give feedback.
-
Before merging website to this repo:
Add journeys in the sidebar using Vue.js (assigned to @vikasganiga05)
Get a domain in place
- I can get a .tech domain, etc for free using GitHub Student Plan, but if fine, we can get a freenom domain coz I may want to use the .tech in future.
- @Adarsh-jaiss Please sign up for the GitHub Student Plan, then we use your .tech domain if that's fine with you
Before or after merging to this repo:
gh-action to update text (sections) from README.md to the individual page of the website (not so important)
gh-action to hyperlink the name of the user from .json file and link their journey via a hyperlink in the sidebar
Maybe add a navbar.
@vikasganiga05 As your the docsify expert, Will require your help to merge the website to this repo once done with the above,
Thanks,
KendallDoesCoding
Beta Was this translation helpful? Give feedback.
All reactions