Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DSL should warn/error when setting output_fields for java spouts #123

Open
dgolombek opened this issue Sep 2, 2014 · 0 comments
Open

DSL should warn/error when setting output_fields for java spouts #123

dgolombek opened this issue Sep 2, 2014 · 0 comments

Comments

@dgolombek
Copy link

The DSL happily pretends to set output_fields for spouts implemented in java, but then drops them on the floor (https://github.com/colinsurprenant/redstorm/blob/master/lib%2Fred_storm%2Fdsl%2Ftopology.rb#L48). We can either try to fix this correctly (check if the spout implements ISchemableSpout or IMultiSchemableSpout and if so set the scheme via it, otherwise give up and raise) or we can just give up and raise an error (which would make #99 even more important to fix). Let me know what you think (or if I'm missing something) and I can submit a patch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant