Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add more tests #8

Merged
merged 2 commits into from
Apr 12, 2017
Merged

add more tests #8

merged 2 commits into from
Apr 12, 2017

Conversation

dsyme
Copy link
Collaborator

@dsyme dsyme commented Apr 12, 2017

@colinbull Could you take a look at this? Testing strategy is to have the sample erasing TP simply reify a set of static values which reveal what the type provider is told about the type involved, and to check those things correspond roughly to the values given by .NET reflection over the typeof of the type.

We repeat this for a number of types.

Note there are a fair number of inaccuracies/bugs for the reasons noted in the tests. The devil is in the detail :) In particular every time the TAST is different to the .NET compiled form we see it. (e.g. because of all the crap we do in IlxGen.fs)

Haven't done anything with

  • generic types
  • generic methods
  • custom attributes (these are important I think since they may guide the TP)
  • events
  • fields
  • generic parameters
  • ...

@dsyme
Copy link
Collaborator Author

dsyme commented Apr 12, 2017

Note I do this steps to run the tests:

build net40 debug

then

cd tests\fsharp\typeProviders\samples\TypePassing\Erasing
.paket\paket.bootstrapper.exe
.paket\paket.exe install

And then iterate with

msbuild && ..\..\..\..\..\..\debug\net40\bin\fsc.exe script.fsx && .\script.exe

in that directory

@dsyme dsyme merged commit c295f8a into colinbull:rfc/fs-1023-type-providers Apr 12, 2017
@colinbull
Copy link
Owner

Ok no problem I can have a look at this tomorrow evening.. been fighting the enterprise devils today and it takes all the strength I can muster. ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants