Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporal testing fails for :terminate_if_running reuse policy #306

Open
iegomez opened this issue Jul 11, 2024 · 0 comments
Open

Temporal testing fails for :terminate_if_running reuse policy #306

iegomez opened this issue Jul 11, 2024 · 0 comments

Comments

@iegomez
Copy link

iegomez commented Jul 11, 2024

When enabling testing, the gem runs this check on workflows:

w_id == workflow_id && disallowed_statuses.include?(execution.status)

The problem is that disallowed_statuses (at

def disallowed_statuses_for(reuse_policy)
) doesn't consider the valid terminate_if_running reuse policy, thus crashing at disallowed_statuses.include?(execution.status) due to it returning nil.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant