Return a 1x1 image when bbox is smaller than a single pixel #637
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was originally motivated by hitting a zero-division error when calling
Reader.feature
with a feature that happened to be smaller than one pixel in the image:I traced it back to the result of
part
being a 0x0 image when the bbox was smaller than a single pixel of the image, which this change fixes and returns a 1x1 image instead.I'm not 100% sure about this, but it seems to make sense to me that
part
returning a single pixel is the correct outcome for this case, as this is still the valid image data for the bbox being requested.