second but now tested Tasks generator with/without threads #291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincentsarago
commented
Oct 22, 2020
| @@ -73,7 +73,7 @@ def reader(asset: str, *args, **kwargs) -> Tuple[numpy.ndarray, numpy.ndarray]: | |||
| ) | |||
|
|
|||
| if not chunk_size: | |||
| chunk_size = threads or len(assets) | |||
| chunk_size = threads if threads > 1 else len(assets) | |||
There was a problem hiding this comment.
this explains why it was fine with threads=1, because we were processing chunks of one element.
vincentsarago
commented
Oct 22, 2020
| @@ -222,18 +221,64 @@ def test_mosaic_tiler_Stdev(): | |||
|
|
|||
| def test_threads(): | |||
| """Test mosaic tiler.""" | |||
| assets = [asset1, asset2, asset1, asset2, asset1, asset2] | |||
| assets = [asset2, asset1, asset1, asset2, asset1, asset2] | |||
There was a problem hiding this comment.
Simple but important changes, before we were just lucky because the tiler was first yielding result for asset1. This change was made during testing to validate the new implementation
vincentsarago
commented
Oct 22, 2020
vincentsarago
commented
Oct 22, 2020
| @@ -44,15 +47,9 @@ def filter_tasks( | |||
| if not allowed_exceptions: | |||
| allowed_exceptions = () | |||
|
|
|||
| while True: | |||
| for (future, asset) in tasks: | |||
There was a problem hiding this comment.
because we don't need generators anymore we can switch back to simple Sequence
kylebarron
approved these changes
Oct 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
re-do of #281
1 threadbecause of abugcc @kylebarron @geospatial-jeff