Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid direct Fail trait implementation #188

Open
drahnr opened this issue Aug 31, 2020 · 0 comments
Open

Avoid direct Fail trait implementation #188

drahnr opened this issue Aug 31, 2020 · 0 comments

Comments

@drahnr
Copy link
Contributor

drahnr commented Aug 31, 2020

First of all, thank you for this exceptional crate!

I have a usability nitpick though. The error type does not implement the error trait, and hence makes it harder to use than necessary when combined with anyhow or friends, which rely on the fact that trait Error is implemented for automatic conversion.

Now with the trait Fail impl one runs into rustc errors which suggest to add .map_err(|e| e.into())? when using anyhow since the auto conversion fails.

Moving away from failure to i.e. thiserror would simplify error handling or just implementing trait Error from std would also suffice.

I'd be happy to hear your thoughts and if necessary create a PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant