Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexpected prefixing of "for" in PHP Docblock/comments #120

Open
remyperona opened this issue Feb 2, 2021 · 2 comments
Open

Unexpected prefixing of "for" in PHP Docblock/comments #120

remyperona opened this issue Feb 2, 2021 · 2 comments

Comments

@remyperona
Copy link

  • Using v0.7

Bug description
After updating to version 0.7 and running the compose command, I noticed that the word for was prefixed with the classmap_prefix_ defined in the composer configuration, for our dependencies using classmap.

As an example, here is an original docblock:

/**
 * Maybe handle
 *
 * Check for correct nonce and pass to handler.
 */

and the resulting one:

/**
 * Maybe handle
 *
 * Check Prefix_for correct nonce and pass to handler.
 */

It also did the same thing inside inline comments:
// If positive match is found, store the results for debug.
// If positive match is found, store the results Prefix_for debug.

I didn't see any other word on which this happened.

It's not breaking anything as far as I can see, but something for you to look into. And fixing it will also prevent unexpected diff on our repos when updating dependencies.

@BrianHenryIE
Copy link
Contributor

Presumably fixed by #102

@tn3rb
Copy link

tn3rb commented Apr 26, 2023

getting same thing with to

image

	"extra": {
		"mozart": {
			"dep_namespace": "MyVendor\\Dependencies\\",
			"dep_directory": "/Dependencies/",
			"classmap_directory": "/Dependencies/autoload/",
			"classmap_prefix": "EECD_",
			"packages": [
				"dompdf/dompdf",
				"endyjasmi/cuid",
				"tijsverkoyen/css-to-inline-styles",
				"jaybizzle/crawler-detect",
				"wp-graphql/wp-graphql"
			],
			"delete_vendor_directories": true
		}
	},
	"scripts": {
		"post-install-cmd": [
			"\"vendor/bin/mozart\" compose",
			"composer dump-autoload"
		],
		"post-update-cmd": [
			"\"vendor/bin/mozart\" compose",
			"composer dump-autoload"
		]
	}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants