Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Karma doesn't fail on jsxhint-loader failure #94

Closed
melbarra88 opened this issue Nov 19, 2015 · 2 comments
Closed

Karma doesn't fail on jsxhint-loader failure #94

melbarra88 opened this issue Nov 19, 2015 · 2 comments

Comments

@melbarra88
Copy link

Hi,

I am trying to make my dev process fail fast on jsxhint error because there is no need to run tests when script doesn't satisfies jsxhint.

I am using jsxhint-laoder as a preLoader. when built directly with webpack, the jsxhint errors make build fail, but with karma-webpack, It doesn't prevent tests from running on error.

here is my jsxhint-loader :

module.exports = {
    ...
    module: {
        preLoaders: [
            {
                test: /\.js.?$/,
                exclude: [/node_modules/, /vendor/],
                loader: "jsxhint-loader"
            }
        ],
      loaders: [ ... ]
    },
     jshint: {
        emitErrors: true,
        failOnHint: true
    }
};

How can I make my dev process fail fast?
Thanks in advance.

@goldhand
Copy link
Collaborator

I think this might be related to #66

@joshwiens joshwiens removed the question label May 1, 2017
@codymikol
Copy link
Owner

Closing due to the age of this ticket, if you're still having issues with the current build feel free to open a new ticket with the relevant information and I'll help as best I can!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants