-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.0.0-rc4] Regression after removing lodash (when using multi-compiler mode) #390
Comments
Good catch! Feel free to make a pull request if you have time! |
Yep I'm working on it :) |
Unsure if this is related, however I'm getting the same error when using a multi-compiler config, but I'm on webpack-karma version 3.0.5. The error I get is:
My Karma configuration is as follows:
My webpack config is a little large (first time using it), but it builds fine. On a side note, feel free to ignore this but I haven't found anything on the subject, but is there a way to disable security policies on browsers that Karma tests on? I need to run tests that use the |
Closing as this seems to have been fixed with 63cfd78 |
In #364
_.clone
was replaced withObject.assign
.This change assumed that
webpackOptions
is always an object, but in fact, it can be an array (multi-compiler mode, see https://github.com/webpack/webpack/tree/master/examples/multi-compiler).So after this change, an array
[ objA, objB ]
becomes an object{ 0: objA, 1: objB }
and then some subsequent logic gets changed, but also the subsequentwebpack(...)
call checks the passed config and throws an error:I propose to rollback this change then. But instead of using
lodash
we could uselodash.clone
: https://www.npmjs.com/package/lodash.clone as it's the only lodash method used.The text was updated successfully, but these errors were encountered: