Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch authentication from phone to email #10

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

skrashevich
Copy link

@skrashevich skrashevich commented Feb 11, 2024

Changed the Yeelock integration authentication method from using a phone number and country code to using an email address. Updated the related API endpoint and parameters for login, removed the phone and country code fields from the config flow, and updated the user interface strings to reflect these changes.

This commit improves the user experience by simplifying the login process and aligns with the Yeelock's updated authentication system that now uses email instead of phone numbers. It also includes modifications to the API calls to use the new endpoint and removes obsolete constants and schema entries.

Fix #8

Changed the Yeelock integration authentication method from using a phone number and country code to using an email address. Updated the related API endpoint and parameters for login, removed the phone and country code fields from the config flow, and updated the user interface strings to reflect these changes.

This commit improves the user experience by simplifying the login process and aligns with the Yeelock's updated authentication system that now uses email instead of phone numbers. It also includes modifications to the API calls to use the new endpoint and removes obsolete constants and schema entries. Translations and documentation have been updated accordingly to guide the user through the new setup process.
@codyc1515
Copy link
Owner

Thank you. I will take a look at this. Ideally we can retain both methods.

@codyc1515
Copy link
Owner

Can we retain both methods?

@codyc1515 codyc1515 marked this pull request as draft April 29, 2024 23:12
@codyc1515 codyc1515 added enhancement New feature or request question Further information is requested labels Apr 29, 2024
@skrashevich
Copy link
Author

skrashevich commented Apr 29, 2024

Can we retain both methods?

it's possible. but i can't do it: in my country auth by phone is not available

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot pair my account
2 participants