DDF-2644 Fixes issue with datepicker dependency that was switched to npm #1620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Built this change locally and attempted to test it.
Here's what it looks like for me (this is Firefox, but it looks the same in Chrome). So, in the case where I have just selected a new date, I see it update in the textbox, however, I have to move my mouse off of the option I have just selected to actually see it highlighted.
|
pklinef
approved these changes
Feb 2, 2017
rzwiefel
approved these changes
Feb 2, 2017
andrewkfiedler
force-pushed
the
DDF-2644-DatepickerIssue
branch
from
5e2e7c6 to
1581bf1
Compare
vinamartin
approved these changes
Feb 6, 2017
andrewkfiedler
force-pushed
the
DDF-2644-DatepickerIssue
branch
from
417668f to
1581bf1
Compare
- The datepicker was switched from being resolved through bower to being resolved through npm recently, with codice@fc8a567 - Unfortunately, the css has been missing since that commit. When I added the css back in using webpack, I noticed the datepicker had some regressions. As such, I rolled it back to the original bower version. - Updates bootstrapDatepicker less to provide a better experience when hovering over the active dates, and to better match the rest of the UI color scheme
andrewkfiedler
force-pushed
the
DDF-2644-DatepickerIssue
branch
from
1581bf1 to
c1883c3
Compare
lavoywj
pushed a commit
to lavoywj/ddf
that referenced
this pull request
Feb 13, 2020
…npm (codice#1620) - The datepicker was switched from being resolved through bower to being resolved through npm recently, with codice@fc8a567 - Unfortunately, the css has been missing since that commit. When I added the css back in using webpack, I noticed the datepicker had some regressions. As such, I rolled it back to the original bower version. - Updates bootstrapDatepicker less to provide a better experience when hovering over the active dates, and to better match the rest of the UI color scheme
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Who is reviewing it (please choose AT LEAST two reviewers that need to approve the PR before it can get merged)?
@andrewkfiedler
@pklinef
@djblue
@rzwiefel
@tbatie
How should this be tested? (List steps with links to updated documentation)
Check out the Catalog UI and ensure the datepicker has the correct css.