test improved

codex-team · Jul 24, 2024 · e0605dc · e0605dc
1 parent fa16dd4
commit e0605dc
Show file tree

Hide file tree

Showing 3 changed files with 26 additions and 21 deletions.
diff --git a/src/presentation/http/router/note.test.ts b/src/presentation/http/router/note.test.ts
@@ -717,6 +717,14 @@ describe('Note API', () => {
       expect(response?.json().message).toStrictEqual(expectedMessage);
     });
 
+    // test.each
+    //
+    //
+    //
+    //
+    //
+    //
+
     test.todo('Returns 400 when parentId has incorrect characters and length');
   });
 
@@ -1882,23 +1890,18 @@ describe('Note API', () => {
       if (expectedMessage !== null) {
         expect(response?.json()).toStrictEqual({ message: expectedMessage });
       } else {
-        expect(response?.json().noteHistoryMeta).toMatchObject([
+        expect(response?.json().noteHistoryMeta).toStrictEqual([
           /**
            * First history record created automatically on note insertion
            */
           {
-            id: '1',
-            noteId: note.publicId,
+            id: 1,
             userId: creator.id,
-            content: note.content,
-            tools: note.tools,
           },
           {
             id: history.id,
-            noteId: history.noteId,
             userId: history.userId,
-            content: history.content,
-            tools: history.tools,
+            createdAt: history.createdAt,
           },
         ]);
       }

diff --git a/src/presentation/http/router/note.ts b/src/presentation/http/router/note.ts
@@ -678,7 +678,7 @@ const NoteRouter: FastifyPluginCallback<NoteRouterOptions> = (fastify, opts, don
             noteHistoryMeta: {
               type: 'array',
               items: {
-                $ref: 'HistoryMetaSchema#',
+                $ref: 'HistoryMetaSchema',
               },
             },
           },

diff --git a/src/presentation/http/schema/History.ts b/src/presentation/http/schema/History.ts
@@ -70,17 +70,19 @@ export const HistoryMetaSchema = {
     'userId',
     'createdAt',
   ],
-  id: {
-    description: 'unique note hisotry record identifier',
-    type: 'number',
-  },
-  userId: {
-    description: 'unique user identifier',
-    type: 'number',
-  },
-  createdAt: {
-    description: 'time, when note history record was created',
-    type: 'string',
-    format: 'date-time',
+  properties: {
+    id: {
+      description: 'unique note hisotry record identifier',
+      type: 'number',
+    },
+    userId: {
+      description: 'unique user identifier',
+      type: 'number',
+    },
+    createdAt: {
+      description: 'time, when note history record was created',
+      type: 'string',
+      format: 'date-time',
+    },
   },
 };