Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: wrong example for convertTo i18n #2839

Open
xXNickznXx opened this issue Oct 8, 2024 · 4 comments
Open

Docs: wrong example for convertTo i18n #2839

xXNickznXx opened this issue Oct 8, 2024 · 4 comments

Comments

@xXNickznXx
Copy link

Steps to reproduce

  1. Open https://stackblitz.com/edit/nickzn-editorjs?file=src%2Fmain.ts
  2. Mark "text"
  3. Hover over "convertTo" inlinetool
  4. The tooltip displays "Convert to"

Expected behavior

It should display "cccc"

Editor.js version

2.30.x
On 2.29.1 it worked.

Plugins you use with their versions

  • @editorjs/header: 2.8.7
@xXNickznXx xXNickznXx added the bug label Oct 8, 2024
@neSpecc
Copy link
Member

neSpecc commented Oct 8, 2024

it was fixed in 2.30.2. Update to the latest version and check again please

@neSpecc neSpecc closed this as completed Oct 8, 2024
@xXNickznXx
Copy link
Author

@neSpecc just look at the stackblitz, im using 2.30.6 there

@neSpecc neSpecc reopened this Oct 8, 2024
@neSpecc
Copy link
Member

neSpecc commented Oct 8, 2024

Tokens location has been changed.

Use following paths:

i18n: {
  messages: {
    ui: {
      // for block tunes menu
      popover: {
        "Convert to": "Конвертировать в",
      }
    },
    tools: {
      // for inline toolbar hint
      convertTo: {
        "Convert to": "Конвертировать в",
      }
    },
  }
}

@neSpecc neSpecc closed this as completed Oct 8, 2024
@neSpecc neSpecc reopened this Oct 8, 2024
@neSpecc neSpecc added issue for docs and removed bug labels Oct 8, 2024
@neSpecc neSpecc changed the title [Bug] - inlineToolbar convertTo cant be translated anymore Docs: wrong example for convertTo i18n Oct 8, 2024
@xXNickznXx
Copy link
Author

That works, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants