Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] 2.24.0 - Tool title is not translated anymore #2030

Closed
christoph-kluge opened this issue Apr 26, 2022 · 2 comments · Fixed by #2031
Closed

[Bug] 2.24.0 - Tool title is not translated anymore #2030

christoph-kluge opened this issue Apr 26, 2022 · 2 comments · Fixed by #2031
Assignees
@TatianaFomina
Labels
bug important

Comments

@christoph-kluge
Copy link

Upgrading from 2.23.2 to 2.24.0 has a regression for tool title translations.

Screenshots:

Before:

Screenshot 2022-04-26 at 23 19 30

After:

Screenshot 2022-04-26 at 23 19 45
@TatianaFomina TatianaFomina linked a pull request Apr 27, 2022 that will close this issue
fix(ui): toolbox items labels i18n #2031
Merged
@neSpecc
Copy link
Member

neSpecc commented Apr 28, 2022

BTW, Why the Toolbox text colour is gray? Have you override it? Because it should be black.

@christoph-kluge
Copy link
Author

Context: I use tailwind with dark-mode. I'm setting the basic text-color close to beginning of the body tag.

Just checked it inside DevTools. EditorJS inhert's from that.

Tanks for fixing the i18n issue so quickly 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TatianaFomina TatianaFomina

Labels
bug important
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(ui): toolbox items labels i18n codex-team/editor.js
3 participants
@christoph-kluge @neSpecc @TatianaFomina