Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slow load times for extras #11

Closed
Kacarott opened this issue Jan 28, 2024 · 3 comments
Closed

Slow load times for extras #11

Kacarott opened this issue Jan 28, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@Kacarott
Copy link
Collaborator

In 0.99, some commonly used vocabularies in extras now take a considerable amount of time to load. For example simply loading sequences.extras adds 5-6 seconds to the runtime.

Commonly used vocabs from extras should be preloaded so that load times do not affect code runtime.

@Kacarott Kacarott added the bug Something isn't working label Jan 30, 2024
@nomennescio nomennescio removed the bug Something isn't working label Jan 31, 2024
@nomennescio
Copy link
Collaborator

I wouldn't label this a bug; extras was not preloaded in 0.98, and also not in 0.99.
I understand your argument that some vocabs in extras deserve to be promoted to being preloaded.
Good idea, but will do that in testest.

@Kacarott
Copy link
Collaborator Author

It is definitely a bug, because it makes extras unusable for performance kata in 0.99. In 0.98 it took only about 1 second to load sequences.extras, in 0.99 it takes 5-6 seconds.

It should be done here, as this is has nothing to do with testest. See #13

@Kacarott Kacarott reopened this Jan 31, 2024
@Kacarott Kacarott added the bug Something isn't working label Jan 31, 2024
@nomennescio
Copy link
Collaborator

See #13, I will address this in testest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants