Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

await new Promise((resolve) => setTimeout(() => resolve(), 500)) #137

Open
vaibhavdaren opened this issue Jun 18, 2020 · 0 comments
Open

Comments

@vaibhavdaren
Copy link
Member

Fix tests

can you explain this
await new Promise((resolve) => setTimeout(() => resolve(), 500))

during the shutdown of superset, somewhere the thread is not waiting for an async system operation to finish. Thus, the operation is delegated to the system but the execution is not blocked or does not wait for the async operation to finish. In the meantime, the test case execution finishes, jest is shutting down and complains about an open handle. So this is making the jest to wait for some time to finish the execution and disable the open handle issue, during npm run test

Originally posted by @Rupeshiya in #135 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant