-
Notifications
You must be signed in to change notification settings - Fork 472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more misspelled words #1598
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one comment
@@ -9279,6 +9280,7 @@ disignated->designated | |||
disinguish->distinguish | |||
disiplined->disciplined | |||
disired->desired | |||
diskretization->discretization |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add the sation variant as a separate typo please.
Also the Wikipedia page mentions discretized, so it might be worth adding this typo against that word and maybe also discrete, discretely, discretion etc. Possibly also discuss etc (although grep.app doesn't find examples of the latter).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added some of your suggestions. I think I will make/lookup a list of commonly misspelled words by germans and add it in my holidays.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@peternewman i don't understand the travis checks.
f.e. diskretization is for sure not in aspell, since it is wrong.
or https://en.wiktionary.org/wiki/discretise exists :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added some of your suggestions. I think I will make/lookup a list of commonly misspelled words by germans and add it in my holidays.
Great, the trick there is probably to add a new dictionary called dictionary-de.txt and if necessary move anything in the main dictionary that's a valid German word (like some of my other suggestions) out into a dictionary-en.txt (and make that default). Then ideally make Travis check all that complication too!
@peternewman i don't understand the travis checks.
f.e. diskretization is for sure not in aspell, since it is wrong.
or https://en.wiktionary.org/wiki/discretise exists :-)
See my comments for some further explanation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few comments, it seems my suggestions are ahead of where we are in terms of practicality.
Two common mistakes of my group