Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Download a custom Aspell dictionary and build it #1485

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from
Draft

Download a custom Aspell dictionary and build it #1485

wants to merge 9 commits into from

Conversation

peternewman
Copy link
Collaborator

@peternewman peternewman commented Apr 18, 2020 •
edited by DimitriPapadopoulos
Loading

Fixes #2657?

@peternewman peternewman mentioned this pull request May 11, 2020
Merged
@peternewman peternewman mentioned this pull request Jun 12, 2020
Open
@peternewman peternewman mentioned this pull request Jul 22, 2020
Merged
sebweb3r added a commit to sebweb3r/codespell that referenced this pull request Jul 22, 2020
@sebweb3r
Deleted words not included in aspell.
059758d 
See codespell-project#1598 and codespell-project#1485
@sebweb3r sebweb3r mentioned this pull request Aug 11, 2020
Open
@peternewman peternewman mentioned this pull request Aug 17, 2020
Open
This was referenced Aug 30, 2020
Open
Merged
@peternewman peternewman mentioned this pull request Sep 2, 2020
Merged
@sebweb3r
Copy link
Contributor

I played around a little bit. With

    speller = aspell.Speller(('master', '/tmp/aspell6-en-custom/en-custom.rws'))

it worked for me. However, alot of words that are fixed by codespell exist in the big dictionary dictionary. Thus, the test fail.
See the output.txt

Maybe the dictionary is to big.

lurch
lurch reviewed Nov 12, 2020
View reviewed changes
codespell_lib/data/dictionary_rare.txt
@@ -89,6 +89,7 @@ panting->painting
payed->paid
planed->planned
pleas->please
pneumonic->mnemonic, pneumonia,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess pneumatic is probably "too different"?

lurch
lurch reviewed Nov 12, 2020
View reviewed changes
codespell_lib/tests/test_dictionary.py
@@ -12,7 +12,8 @@

try:
import aspell
speller = aspell.Speller('lang', 'en')
#speller = aspell.Speller('lang', 'en')
speller = aspell.Speller(('lang', 'en-custom'), ('data-dir', '/home/travis/build/codespell-project/codespell/aspell6-en-custom/'))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably makes sense to tweak this to not rely on a hardcoded /home/travis/... path?

@DimitriPapadopoulos DimitriPapadopoulos mentioned this pull request Feb 14, 2023
Closed
@DimitriPapadopoulos DimitriPapadopoulos mentioned this pull request Jul 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lurch lurch lurch left review comments

@larsoner larsoner Awaiting requested review from larsoner larsoner will be requested when the pull request is marked ready for review larsoner is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add donut, and other words missing from aspell
3 participants
@peternewman @sebweb3r @lurch