Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pre-commit.ci and use local hook to auto-run make sort-dictionaries on PRs #2689

Closed
janosh opened this issue Dec 29, 2022 · 0 comments · Fixed by #2973
Closed

Add pre-commit.ci and use local hook to auto-run make sort-dictionaries on PRs #2689

janosh opened this issue Dec 29, 2022 · 0 comments · Fixed by #2973

Comments

@janosh
Copy link
Contributor

janosh commented Dec 29, 2022

pre-commit.ci supports local hooks which could be used in this repo to safely run make sort-dictionaries on PRs.

It's a bit tedious to have to download the repo (I prefer https://github.dev for small PRs) just to get a terminal from which to run sorting manually.
kurtmckee added a commit to kurtmckee/pr-codespell that referenced this issue Jul 27, 2023
@kurtmckee
Use pre-commit to sort the dictionaries
3cb95ab 
This changes the sort order of specific characters (like `"_"`)
but is cross-platform and can be fixed by pre-commit.ci.

Closes codespell-project#2689
@kurtmckee kurtmckee mentioned this issue Jul 27, 2023
Merged
kurtmckee added a commit to kurtmckee/pr-codespell that referenced this issue Jul 27, 2023
@kurtmckee
Use pre-commit to sort the dictionaries
212f0d3 
This changes the sort order of specific characters (like `"_"`)
but is cross-platform and can be fixed by pre-commit.ci.

Closes codespell-project#2689
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use pre-commit to sort the dictionaries kurtmckee/pr-codespell
1 participant
@janosh