Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting encryption key before joining the group #192

Open
ayurchen opened this issue Aug 15, 2022 · 0 comments
Open

Allow setting encryption key before joining the group #192

ayurchen opened this issue Aug 15, 2022 · 0 comments

Comments

@ayurchen
Copy link
Member

Otherwise there is a plaintext leak in the very beginning of the writeset stream.

Currently src/server_state.cpp has

wsrep::server_state::set_encryption_key(std::vector<unsigned char>& key)
{
    encryption_key_ = key;
    if (state_ != s_disconnected)
    {
      ...

i.e. setting the key is skipped if provider is not connected. This is clearly a mistake as we need the key to be set before provider starts to receive and cache any data.

ayurchen added a commit that referenced this issue Aug 15, 2022
`server_state::set_encryption_key()`

Refs #192
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant