Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can sign up in multiple concurrent shifts #299

Closed
leodabbler opened this issue Dec 5, 2015 · 6 comments
Closed

Can sign up in multiple concurrent shifts #299

leodabbler opened this issue Dec 5, 2015 · 6 comments
Labels

Comments

@leodabbler
Copy link
Contributor

I was able to sign up in concurrent shifts simultaneously. Shouldn't I get a warning, at least?

I'm not a user of volunteer-planner, but interested in coding for it and attempting to understand the application and its requirements.

@klinger
Copy link
Contributor

klinger commented Dec 7, 2015

Thanks.
I second that: I think there should at least be a warning. I couldnt think of a situation where concurrent shifts should be allowed. But its important to offer #300 to the user first. Should we forbid signing up for concurrent shifts? Opinions?

@DaniGr
Copy link

DaniGr commented Dec 20, 2015

Yes forbid please! This was actually the first issue I entered :) Would be more than happy if it would be fixed! Please note that slightly overlapping shifts shouldn't be forbidden (as some facilities have a short overlap in sequencing shifts so that there's a transition period). In this case there should only be a warning (or probably in all cases).

@numberpi
Copy link
Contributor

numberpi commented Sep 8, 2016

Already fixed in version 1.3.0

@klinger
Copy link
Contributor

klinger commented Sep 8, 2016

Did you test it? The release of 1.3 was 14.09.2015. This issue is from 05.12.2015.

@numberpi
Copy link
Contributor

Yes and #393 also fixes problems with shifts having a duration <= 1h.
At the moment, you can join two concurrent shifts, if they overlap not more than one hour (to regard transition periods).

@numberpi
Copy link
Contributor

But I will open a new issue, that you always get a warning, when you sing in to an overlapping shift. (#395)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants