Add websocket.CloseStatus #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Will make it much more convenient and less error prone to access the StatusCode of a *CloseError.
nhooyr
commented
Oct 5, 2019
| } | ||
| return -1 | ||
| } | ||
|
|
There was a problem hiding this comment.
This is the main addition in this PR, the rest is just some refactoring to allow the use of assert.Equalf in the tests for this function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will make it much more convenient and less error prone to access
the StatusCode of a *CloseError.
Related #128
Precedent for this is in https://godoc.org/gocloud.dev/gcerrors#Code
It's annoying to do the whole xerrors.As dance when you only want to access the status code.
I was only blocked on the name for this but I think
CloseStatusis nice.@ammar @coadler