Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configurable buffer sizes #65

Closed
nhooyr opened this issue Apr 21, 2019 · 4 comments
Closed

Configurable buffer sizes #65

nhooyr opened this issue Apr 21, 2019 · 4 comments
Labels
blocked

Comments

@nhooyr
Copy link
Contributor

nhooyr commented Apr 21, 2019

Not sure how beneficial this will really be. I really do not want to expose a toggle.

Will wait to see what happens with golang/go#22618
@nhooyr nhooyr mentioned this issue Apr 21, 2019
Closed
3 tasks
@nhooyr nhooyr added perf and removed enhancement labels Apr 21, 2019
@nhooyr nhooyr mentioned this issue Apr 29, 2019
Closed
@nhooyr nhooyr added the blocked label Apr 29, 2019
@nhooyr
Copy link
Contributor Author

nhooyr commented May 1, 2019

Looks like the net/http transport has added configurable buffer sizes so I guess we ought to do it too.

@nhooyr
Copy link
Contributor Author

nhooyr commented May 17, 2019

In retrospect, it's not the same thing. They added configurable buffer sizes to the transport because the io.Copy is done by the transport, so you can't wrap the connection being written to with your own bufio.Writer like you can with this library.

So the issue we're blocked on is: golang/go#13870

@nhooyr
Copy link
Contributor Author

nhooyr commented May 26, 2019

Going to just close this for now until that bug is updated/fixed.

@nhooyr nhooyr closed this as completed May 26, 2019
@nhooyr
Copy link
Contributor Author

nhooyr commented Jun 7, 2020

See also #250

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
blocked
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nhooyr