Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Less strict about message type of JSON payload #233

Closed
typeless opened this issue May 5, 2020 · 1 comment · Fixed by #234
Closed

Less strict about message type of JSON payload #233

typeless opened this issue May 5, 2020 · 1 comment · Fixed by #234
Labels
enhancement

Comments

@typeless
Copy link
Contributor

typeless commented May 5, 2020

I am troubleshooting a stock broker's API that employs WebSocket.
It turns out that it sends JSON payloads with the binary type, which makes the wsjson API unusable.

Please consider removing the restriction if that makes sense.
@nhooyr
Copy link
Contributor

nhooyr commented May 5, 2020

Yea I suppose it isn't really a big deal for wsjson whether the message type is binary or text.

@typeless typeless mentioned this issue May 5, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Less strict about message type of JSON payloads typeless/websocket
2 participants
@typeless @nhooyr