Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Outdated documentation re close handshake timeout #212

Closed
zhangyoufu opened this issue Mar 15, 2020 · 1 comment
Closed

Outdated documentation re close handshake timeout #212

zhangyoufu opened this issue Mar 15, 2020 · 1 comment
Labels
docs
Milestone
v1.8.5

Comments

@zhangyoufu
Copy link

https://github.com/nhooyr/websocket/blob/ff876f6d14d96bf1de6094887d6bbf167991b046/close_notjs.go#L18-L19

https://github.com/nhooyr/websocket/blob/ff876f6d14d96bf1de6094887d6bbf167991b046/close_notjs.go#L83-L87

Conn.Close may block for up to 5s (stuck in writeControl due to congestion control, w/o triggering timeout) + 10s (wait peer).
@nhooyr
Copy link
Contributor

nhooyr commented Mar 15, 2020

Nice catch, will fix soon.

@nhooyr nhooyr added the docs label Mar 15, 2020
@nhooyr nhooyr changed the title mismatch between document and implementation of Conn.Close Outdated documentation re close handshake timeout Mar 17, 2020
@nhooyr nhooyr added this to the v1.8.5 milestone Apr 13, 2020
@nhooyr nhooyr closed this as completed in 98779ee Apr 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
docs
Projects
None yet
Milestone
v1.8.5
Development

No branches or pull requests
2 participants
@zhangyoufu @nhooyr